imay commented on a change in pull request #2067: fix predicate read bug
URL: https://github.com/apache/incubator-doris/pull/2067#discussion_r338915200
##########
File path: be/src/olap/row_block2.cpp
##########
@@ -62,7 +62,7 @@ Status RowBlockV2::convert_to_row_block(RowCursor* helper,
RowBlock* dst) {
if (is_nullable) {
for (uint16_t i = 0; i < _selected_size; ++i) {
uint16_t row_idx = _selection_vector[i];
- dst->get_row(row_idx, helper);
+ dst->get_row(i, helper);
Review comment:
It will be better to add a UT to covert this case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
