kangpinghuang commented on a change in pull request #2083: Support sql mode
URL: https://github.com/apache/incubator-doris/pull/2083#discussion_r339515642
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/SetVar.java
 ##########
 @@ -102,6 +103,18 @@ public void analyze(Analyzer analyzer) throws 
AnalysisException, UserException {
             value = new StringLiteral(((SlotRef) value).getColumnName());
         }
 
+        if (variable.equalsIgnoreCase(SessionVariable.SQL_MODE)) {
 
 Review comment:
   I think it is better to move this logic to line 128

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to