gaodayue commented on issue #2075: Segment v2 stream load core dump(#2037) URL: https://github.com/apache/incubator-doris/pull/2075#issuecomment-547282513 > My suggestion is to combine Slice finish() and Slice release() into OwnedSlice finish(). OwnedSlice owns slice's data and is a move-only type. This will make ownership transfer clear and remove all potential bugs. The point is really about use OwnedSlice instead of Slice for ownership transfer to remove potential memory bugs. Whether to keep two versions of `finish` is a less important choice, just follow the KISS principle.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
