xy720 commented on a change in pull request #2083: Support sql mode
URL: https://github.com/apache/incubator-doris/pull/2083#discussion_r339960161
##########
File path: fe/src/main/java/org/apache/doris/analysis/SetVar.java
##########
@@ -102,6 +103,18 @@ public void analyze(Analyzer analyzer) throws
AnalysisException, UserException {
value = new StringLiteral(((SlotRef) value).getColumnName());
}
+ if (variable.equalsIgnoreCase(SessionVariable.SQL_MODE)) {
+ if (value instanceof StringLiteral) {
+ String sqlMode = ((StringLiteral) value).getStringValue();
+ if (!SqlModeHelper.checkValid(sqlMode)) {
+ throw new AnalysisException("Unsupported sql mode found");
Review comment:
fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
