EmmyMiao87 commented on a change in pull request #2093: Fix some routine load 
bugs
URL: https://github.com/apache/incubator-doris/pull/2093#discussion_r340046515
 
 

 ##########
 File path: 
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadJob.java
 ##########
 @@ -757,7 +758,10 @@ public void afterAborted(TransactionState txnState, 
boolean txnOperated, String
                              .add("error_msg", "change job state to paused 
when task has been aborted with error " + e.getMessage())
                              .build(), e);
         } finally {
-            writeUnlock();
+            if (lock.isWriteLockedByCurrentThread()) {
 
 Review comment:
   The function of `afterAborted` could not be call individually. It already 
explain in comments at the top of this function.
   So the case A is illegal. The timeout of txn should not call this function 
individually.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to