imay commented on a change in pull request #2091: fix AlphaRowsetTest by remove
StorageEngine #2078
URL: https://github.com/apache/incubator-doris/pull/2091#discussion_r340408031
##########
File path: be/src/olap/rowset/segment_writer.cpp
##########
@@ -227,11 +231,10 @@ OLAPStatus SegmentWriter::finalize(uint32_t*
segment_file_size) {
}
// check disk capacity
- if (data_dir->reach_capacity_limit((int64_t) file_header.file_length())) {
+ if (data_dir != nullptr && data_dir->reach_capacity_limit((int64_t)
file_header.file_length())) {
return OLAP_ERR_DISK_REACH_CAPACITY_LIMIT;
}
- data_dir->add_pending_ids(ROWSET_ID_PREFIX +
_segment_group->rowset_id().to_string());
Review comment:
Why?
I think you should not introduce new problem in on PR.
When we need do in another PR, it must assure that this would not make our
code worse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
