imay commented on a change in pull request #2013: Add arrow IPC serialization
for Doris-Spark-Connector
URL: https://github.com/apache/incubator-doris/pull/2013#discussion_r340554372
##########
File path: be/src/util/arrow/row_batch.h
##########
@@ -71,4 +71,7 @@ Status convert_to_row_batch(
MemTracker* tracker,
std::shared_ptr<RowBatch>* result);
+Status serialize_record_batch(std::shared_ptr<arrow::RecordBatch>
record_batch, std::string* result);
Review comment:
```suggestion
Status serialize_record_batch(const arrow::RecordBatch& record_batch,
std::string* result);
```
Add comment for this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
