imay commented on a change in pull request #2083: Support sql mode URL: https://github.com/apache/incubator-doris/pull/2083#discussion_r340076710
########## File path: fe/src/main/java/org/apache/doris/qe/SqlModeHelper.java ########## @@ -0,0 +1,185 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.qe; + + +import com.google.common.base.Joiner; +import com.google.common.base.Splitter; +import com.google.common.collect.Maps; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +import java.util.ArrayList; +import java.util.List; +import java.util.Map; + +public class SqlModeHelper { + private static final Logger LOG = LogManager.getLogger(SqlModeHelper.class); + + // TODO(xuyang): these mode types are copy from MYSQL mode types, which are example + // of how they works and to be compatible with MySQL, so for now they are not + // really meaningful. + /* Bits for different SQL MODE modes, you can add custom SQL MODE here */ + public static final long MODE_REAL_AS_FLOAT = 1L; + public static final long MODE_PIPES_AS_CONCAT = 2L; + public static final long MODE_ANSI_QUOTES = 4L; + public static final long MODE_IGNORE_SPACE = 8L; + public static final long MODE_NOT_USED = 16L; + public static final long MODE_ONLY_FULL_GROUP_BY = 32L; + public static final long MODE_NO_UNSIGNED_SUBTRACTION = 64L; + public static final long MODE_NO_DIR_IN_CREATE = 128L; + public static final long MODE_NO_AUTO_VALUE_ON_ZERO = 1L << 19; + public static final long MODE_NO_BACKSLASH_ESCAPES = 1L << 20; + public static final long MODE_STRICT_TRANS_TABLES = 1L << 21; + public static final long MODE_STRICT_ALL_TABLES = 1L << 22; + // NO_ZERO_IN_DATE and NO_ZERO_DATE are removed in mysql 5.7 and merged into STRICT MODE. + // However, for backward compatibility during upgrade, these modes are kept. + @Deprecated + public static final long MODE_NO_ZERO_IN_DATE = 1L << 23; + @Deprecated + public static final long MODE_NO_ZERO_DATE = 1L << 24; + public static final long MODE_INVALID_DATES = 1L << 25; + public static final long MODE_ERROR_FOR_DIVISION_BY_ZERO = 1L << 26; + public static final long MODE_HIGH_NOT_PRECEDENCE = 1L <<29; + public static final long MODE_NO_ENGINE_SUBSTITUTION = 1L << 30; + public static final long MODE_PAD_CHAR_TO_FULL_LENGTH = 1L << 31; + public static final long MODE_TIME_TRUNCATE_FRACTIONAL = 1L << 32; + + /* Bits for different COMBINE MODE modes, you can add custom COMBINE MODE here */ + public static final Long MODE_ANSI = 1L << 18; + public static final Long MODE_TRADITIONAL = 1L << 27; + + public final static Long MODE_LAST = 1L << 33; + + public final static Long MODE_ALLOWED_MASK = + (MODE_REAL_AS_FLOAT | MODE_PIPES_AS_CONCAT | MODE_ANSI_QUOTES | + MODE_IGNORE_SPACE | MODE_NOT_USED | MODE_ONLY_FULL_GROUP_BY | + MODE_NO_UNSIGNED_SUBTRACTION | MODE_NO_DIR_IN_CREATE | + MODE_NO_AUTO_VALUE_ON_ZERO | MODE_NO_BACKSLASH_ESCAPES | + MODE_STRICT_TRANS_TABLES | MODE_STRICT_ALL_TABLES | MODE_NO_ZERO_IN_DATE | + MODE_NO_ZERO_DATE | MODE_INVALID_DATES | MODE_ERROR_FOR_DIVISION_BY_ZERO | + MODE_HIGH_NOT_PRECEDENCE | MODE_NO_ENGINE_SUBSTITUTION | + MODE_PAD_CHAR_TO_FULL_LENGTH | MODE_TRADITIONAL | MODE_ANSI | + MODE_TIME_TRUNCATE_FRACTIONAL); + + private final static Map<String, Long> sqlModeSet = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER); + + private final static Map<String, Long> combineModeSet = Maps.newTreeMap(String.CASE_INSENSITIVE_ORDER); + + static { + sqlModeSet.put("REAL_AS_FLOAT", MODE_REAL_AS_FLOAT); + sqlModeSet.put("PIPES_AS_CONCAT", MODE_PIPES_AS_CONCAT); + sqlModeSet.put("ANSI_QUOTES", MODE_ANSI_QUOTES); + sqlModeSet.put("IGNORE_SPACE", MODE_IGNORE_SPACE); + sqlModeSet.put("NOT_USED", MODE_NOT_USED); + sqlModeSet.put("ONLY_FULL_GROUP_BY", MODE_ONLY_FULL_GROUP_BY); + sqlModeSet.put("NO_UNSIGNED_SUBTRACTION", MODE_NO_UNSIGNED_SUBTRACTION); + sqlModeSet.put("NO_DIR_IN_CREATE", MODE_NO_DIR_IN_CREATE); + sqlModeSet.put("ANSI", MODE_ANSI); + sqlModeSet.put("NO_AUTO_VALUE_ON_ZERO", MODE_NO_AUTO_VALUE_ON_ZERO); + sqlModeSet.put("NO_BACKSLASH_ESCAPES", MODE_NO_BACKSLASH_ESCAPES); + sqlModeSet.put("STRICT_TRANS_TABLES", MODE_STRICT_TRANS_TABLES); + sqlModeSet.put("STRICT_ALL_TABLES", MODE_STRICT_ALL_TABLES); + sqlModeSet.put("NO_ZERO_IN_DATE", MODE_NO_ZERO_IN_DATE); + sqlModeSet.put("NO_ZERO_DATE", MODE_NO_ZERO_DATE); + sqlModeSet.put("INVALID_DATES", MODE_INVALID_DATES); + sqlModeSet.put("ERROR_FOR_DIVISION_BY_ZERO", MODE_ERROR_FOR_DIVISION_BY_ZERO); + sqlModeSet.put("TRADITIONAL", MODE_TRADITIONAL); + sqlModeSet.put("HIGH_NOT_PRECEDENCE", MODE_HIGH_NOT_PRECEDENCE); + sqlModeSet.put("NO_ENGINE_SUBSTITUTION", MODE_NO_ENGINE_SUBSTITUTION); + sqlModeSet.put("PAD_CHAR_TO_FULL_LENGTH", MODE_PAD_CHAR_TO_FULL_LENGTH); + sqlModeSet.put("TIME_TRUNCATE_FRACTIONAL", MODE_TIME_TRUNCATE_FRACTIONAL); + + combineModeSet.put("ANSI", (MODE_REAL_AS_FLOAT | MODE_PIPES_AS_CONCAT | + MODE_ANSI_QUOTES | MODE_IGNORE_SPACE | MODE_ONLY_FULL_GROUP_BY)); + combineModeSet.put("TRADITIONAL", (MODE_STRICT_TRANS_TABLES | MODE_STRICT_ALL_TABLES | + MODE_NO_ZERO_IN_DATE | MODE_NO_ZERO_DATE | MODE_ERROR_FOR_DIVISION_BY_ZERO | + MODE_NO_ENGINE_SUBSTITUTION)); + } + + public static String parseValue(Long sqlMode) { + //0 parse to empty string + if (sqlMode == 0 || (sqlMode & ~MODE_ALLOWED_MASK) != 0) { + return ""; + } + + List<String> names = new ArrayList<String>(); + for (Map.Entry<String, Long> mode : getSupportedSqlMode().entrySet()) { + if ((sqlMode & mode.getValue()) != 0) { + names.add(mode.getKey()); + } + } + + return Joiner.on(',').join(names); + } + + public static Long parseString(String sqlMode) { + //empty string parse to 0 + long value = 0L; + List<String> names = + Splitter.on(',').trimResults().omitEmptyStrings().splitToList(sqlMode); + for (String key : names) { + if (getSupportedSqlMode().containsKey(key)) { + value |= getSupportedSqlMode().get(key); + if (isCombineMode(key)) { + value |= getCombineMode().get(key); + } + } + } + + return value; + } + + public static boolean checkValid(String sqlMode) { Review comment: 1. You should add comment to these function to explain what they intent to do. 2. I feel that some of them looks similar, can you try to refactor these to reduce same code? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
