imay commented on a change in pull request #2114: Implement RecordStore to
support UDTF
URL: https://github.com/apache/incubator-doris/pull/2114#discussion_r341147057
##########
File path: be/src/udf/CMakeLists.txt
##########
@@ -26,8 +26,8 @@ set(EXECUTABLE_OUTPUT_PATH "${BUILD_DIR}/src/udf")
# Build this library twice. Once to be linked into the main Doris. This version
# can have dependencies on our other libs. The second version is shipped as
part
# of the UDF sdk, which can't use other libs.
-add_library(Udf udf.cpp udf_ir.cpp)
-add_library(DorisUdf udf.cpp udf_ir.cpp)
+add_library(Udf udf.cpp udf_ir.cpp record_store_impl.cpp)
+add_library(DorisUdf udf.cpp udf_ir.cpp record_store_impl.cpp)
Review comment:
we can't put record_store_impl.cpp to DorisUdf library. The implementation
should not be exposed to UDF developer.
We should only expose interface to UDF developer in order to hide our
implementation. Then when our implementation is changed, already existed UDF
can still work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
