morningman commented on a change in pull request #2156: Change Null-safe equal
operator from cross join to hash join
URL: https://github.com/apache/incubator-doris/pull/2156#discussion_r343624992
##########
File path: be/src/exec/hash_table.cpp
##########
@@ -42,12 +42,18 @@ const char* HashTable::_s_llvm_class_name =
"class.doris::HashTable";
HashTable::HashTable(const vector<ExprContext*>& build_expr_ctxs,
const vector<ExprContext*>& probe_expr_ctxs,
- int num_build_tuples, bool stores_nulls, int32_t
initial_seed,
+ int num_build_tuples, bool null_preserved,
+ const std::vector<bool> finds_nulls,
Review comment:
```suggestion
const std::vector<bool>& finds_nulls,
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
