imay commented on a change in pull request #2156: Change Null-safe equal operator from cross join to hash join URL: https://github.com/apache/incubator-doris/pull/2156#discussion_r343631678
########## File path: fe/src/main/java/org/apache/doris/planner/HashJoinNode.java ########## @@ -53,8 +54,8 @@ private final TableRef innerRef; private final JoinOperator joinOp; - // conjuncts of the form "<lhs> = <rhs>", recorded as Pair(<lhs>, <rhs>) - private List<Pair<Expr, Expr>> eqJoinConjuncts; + // predicates of the form "<lhs> = <rhs>", recorded as Pair(<lhs>, <rhs>) Review comment: why you change conjuncts to predicates? Better to keep it conjuncts, becuase it means `and` and same with `otherJoinConjuncts` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org