kangpinghuang commented on a change in pull request #2055: add delete state of
row block v2 for performance
URL: https://github.com/apache/incubator-doris/pull/2055#discussion_r344590226
##########
File path: be/src/olap/generic_iterators.cpp
##########
@@ -262,6 +266,9 @@ Status MergeIterator::next_batch(RowBlockV2* block) {
// copy current row to block
copy_row(&dst_row, ctx->current_row(), block->pool());
+ if (ctx->is_partial_delete()) {
+ block->set_delete_state(DEL_PARTIAL_SATISFIED);
Review comment:
Here the block is not filtered yet, should should be set delete status.
Delete can be calculated here, but need to refactor condition to realize it.
which will be done in another pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
