kangpinghuang commented on a change in pull request #2050: segment_v2: Support
bitmap index build
URL: https://github.com/apache/incubator-doris/pull/2050#discussion_r348025528
##########
File path: gensrc/proto/segment_v2.proto
##########
@@ -164,3 +166,51 @@ message SegmentFooterPB {
optional PagePointerPB short_key_index_page = 9;
}
+message IndexPageFooterPB {
+ required int32 num_entries = 1;
Review comment:
I think use optional to replace required is better for future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
