imay commented on a change in pull request #2235: Support setting properties
for storage_root_path
URL: https://github.com/apache/incubator-doris/pull/2235#discussion_r348429090
##########
File path: be/src/olap/options.h
##########
@@ -26,14 +26,25 @@
namespace doris {
struct StorePath {
- StorePath() : capacity_bytes(-1) { }
- StorePath(const std::string& path_, int64_t capacity_bytes_)
- : path(path_), capacity_bytes(capacity_bytes_) { }
+ StorePath() : capacity_bytes(-1), storage_medium(TStorageMedium::HDD) { }
+ StorePath(const std::string &path_, int64_t capacity_bytes_)
+ : path(path_),
+ capacity_bytes(capacity_bytes_),
+ storage_medium(TStorageMedium::HDD) { }
+ StorePath(const std::string &path_, int64_t capacity_bytes_,
+ TStorageMedium::type storage_medium_)
+ : path(path_),
+ capacity_bytes(capacity_bytes_),
+ storage_medium(storage_medium_) { }
std::string path;
int64_t capacity_bytes;
+ TStorageMedium::type storage_medium;
};
-OLAPStatus parse_conf_store_paths(const std::string& config_path,
std::vector<StorePath>* path);
+OLAPStatus parse_root_path(const std::string &root_path, StorePath *path);
Review comment:
better to add some comment for this function to let other known what this
function does.
```suggestion
OLAPStatus parse_root_path(const std::string& root_path, StorePath* path);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
