imay commented on a change in pull request #2241: Fix some bugs about load label
URL: https://github.com/apache/incubator-doris/pull/2241#discussion_r349160742
##########
File path: fe/src/main/java/org/apache/doris/load/loadv2/LoadManager.java
##########
@@ -583,6 +595,27 @@ public void updateJobScannedRows(Long jobId, TUniqueId
loadId, TUniqueId fragmen
}
}
+ // in previous implementation, there is a bug that when the job's
corresponding transaction is
+ // COMMITTED but not VISIBLE, the load job's state is LOADING, so that the
job may be CANCELLED
Review comment:
I have a question, when job state is changed to cancelled, is the
corresponding transaction state is checked now? If it isn't, I think it is
better to add this check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
