imay commented on a change in pull request #2277: Replace boost::split() with
strings::Split() in options
URL: https://github.com/apache/incubator-doris/pull/2277#discussion_r349583958
##########
File path: be/src/olap/options.cpp
##########
@@ -17,26 +17,36 @@
#include "olap/options.h"
-#include <boost/algorithm/string.hpp>
-#include <boost/algorithm/string/classification.hpp>
-#include <boost/algorithm/string/split.hpp>
-
#include "common/logging.h"
#include "olap/utils.h"
+#include "gutil/strings/split.h"
+
namespace doris {
+static std::string CAPACITY = "CAPACITY";
+static std::string MEDIUM = "MEDIUM";
+static std::string SSD = "SSD";
+static std::string HDD = "HDD";
+
+// Modify in place
+// TODO: should be a general util method
+std::string to_upper(std::string* str) {
Review comment:
If you intent to modify in place, there is no need to create another string
to return. However it is better to create a new string other than to modify in
place. So I suggest you change it to
```suggestion
std::string to_upper(const std::string& str) {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
