morningman commented on a change in pull request #2305: Add a variable to 
specifically limit the memory usage of the load part in the insert operation
URL: https://github.com/apache/incubator-doris/pull/2305#discussion_r351154437
 
 

 ##########
 File path: be/src/runtime/runtime_state.cpp
 ##########
 @@ -531,5 +531,14 @@ Status RuntimeState::get_codegen(LlvmCodeGen** codegen) {
 Status RuntimeState::StartSpilling(MemTracker* mem_tracker) {
     return Status::InternalError("Mem limit exceeded.");
 }
+
+int64_t RuntimeState::get_load_mem_limit() {
+    if (_query_options.__isset.load_mem_limit && _query_options.load_mem_limit 
> 0) {
 
 Review comment:
   For broker and stream load, user can set mem limit by `exec_mem_limit` 
property wrote in load stmt or http request. And I will use `exec_mem_limit` to 
overwrite `load_mem_limit` in `queryOptions` in query plan.
   
   That is to say, for broker and stream load, user no need to care about this 
`load_mem_limit`,
   and this new variables will make no effect on these kind of load.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to