morningman commented on a change in pull request #2237: Optimize Doris On 
Elasticsearch performance
URL: https://github.com/apache/incubator-doris/pull/2237#discussion_r351664745
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/EsTable.java
 ##########
 @@ -160,34 +225,60 @@ public int getSignature(int signatureVersion) {
     @Override
     public void write(DataOutput out) throws IOException {
         super.write(out);
-        Text.writeString(out, hosts);
-        Text.writeString(out, userName);
-        Text.writeString(out, passwd);
-        Text.writeString(out, indexName);
-        Text.writeString(out, mappingType);
+        out.writeInt(tableContext.size());
+        for (Map.Entry<String, String> entry : tableContext.entrySet()) {
+            Text.writeString(out, entry.getKey());
+            Text.writeString(out, entry.getValue());
+        }
         Text.writeString(out, partitionInfo.getType().name());
         partitionInfo.write(out);
-        Text.writeString(out, transport);
     }
 
     @Override
     public void readFields(DataInput in) throws IOException {
         super.readFields(in);
-        hosts = Text.readString(in);
-        seeds = hosts.split(",");
-        userName = Text.readString(in);
-        passwd = Text.readString(in);
-        indexName = Text.readString(in);
-        mappingType = Text.readString(in);
-        PartitionType partType = PartitionType.valueOf(Text.readString(in));
-        if (partType == PartitionType.UNPARTITIONED) {
-            partitionInfo = SinglePartitionInfo.read(in);
-        } else if (partType == PartitionType.RANGE) {
-            partitionInfo = RangePartitionInfo.read(in);
+        if (Catalog.getCurrentCatalogJournalVersion() >= 
FeMetaVersion.VERSION_66) {
 
 Review comment:
   You need to change to VERSION_68 now

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to