imay commented on a change in pull request #2328: Need to check the return
status of push_memtable
URL: https://github.com/apache/incubator-doris/pull/2328#discussion_r351801852
##########
File path: be/src/olap/memtable_flush_executor.cpp
##########
@@ -95,17 +95,14 @@ MemTableFlushExecutor::~MemTableFlushExecutor() {
queue->shutdown();
}
- // shutdown thread pool
- _flush_pool->shutdown();
- _flush_pool->join();
+ // The threadpool will be shutdown and joined in dtor
+ delete _flush_pool;
Review comment:
I prefer the former method because it is clear. The way you changed is not
clear and has the risk that someone may change the thread_pool's imeplmentation
later
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
