imay commented on a change in pull request #2319: Add Bitmap index reader URL: https://github.com/apache/incubator-doris/pull/2319#discussion_r351993764
########## File path: be/src/olap/column_predicate.h ########## @@ -18,12 +18,18 @@ #ifndef DORIS_BE_SRC_OLAP_COLUMN_PREDICATE_H #define DORIS_BE_SRC_OLAP_COLUMN_PREDICATE_H +#include <roaring/roaring.hh> Review comment: Is it work if replacing this include with forward declaration of Roaring. We prefer including as few as possible in .h files in order to reduce compilation time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
