chaoyli commented on a change in pull request #2212: Add rowset convert
URL: https://github.com/apache/incubator-doris/pull/2212#discussion_r352280679
##########
File path: be/src/olap/snapshot_manager.cpp
##########
@@ -598,11 +558,16 @@ OLAPStatus
SnapshotManager::_convert_beta_rowsets_to_alpha(const TabletMetaShare
res = OLAP_ERR_INIT_FAILED;
break;
}
- new_rowsets->push_back(new_rowset);
+ LOG(INFO) << "convert beta rowset:" << rowset_meta->rowset_id()
+ << " to alpha rowset:" << new_rowset->rowset_id();
+ new_rowsets.push_back(new_rowset);
} else {
- new_rowsets->push_back(rowset_meta);
+ new_rowsets.push_back(rowset_meta);
}
}
+ if (res == OLAP_SUCCESS && modified) {
Review comment:
if request.__isset.missing_version is empty, you should call
new_tablet_meta->revise_rs_metas()
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
