lingbin commented on a change in pull request #2359: Improve SkipList memory
usage tracking
URL: https://github.com/apache/incubator-doris/pull/2359#discussion_r352999166
##########
File path: be/src/olap/skiplist.h
##########
@@ -100,9 +101,11 @@ class SkipList {
// Immutable after construction
Comparator const compare_;
+ bool _can_dup;
Review comment:
I agree the `SkipList` should not know the Doris data model, and that is why
I changed the `Insert()`(which is aware of data model previously) and add the
`_can_dup` member.
And I use `_can_dup` here, just to emphasize that this value can only be
true under a `DUP` model. Other than this, I think `_can_dup` and `_is_unique`
are the same, I don’t have a strong opinion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
