morningman commented on a change in pull request #2364: add a control framework 
between FE and BE through heartbeat #2247
URL: https://github.com/apache/incubator-doris/pull/2364#discussion_r353041392
 
 

 ##########
 File path: be/src/olap/storage_engine.h
 ##########
 @@ -202,6 +203,15 @@ class StorageEngine {
 
     RowsetTypePB compaction_rowset_type() const { return 
_compaction_rowset_type; }
 
+    bool set_default_rowset_type_to_beta() {
 
 Review comment:
   The name `set_default_rowset_type_to_beta` looks like we
   `set the flag`, but what you mean is `is the flag set?`
   I think `is_default_rowset_type_beta()` maybe better?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to