kangkaisen commented on issue #2422: Add copy_object() method for HLL and Bitmap columns when loading URL: https://github.com/apache/incubator-doris/pull/2422#issuecomment-564525569 > Since HLL and bitmap can't be key fields, in fact we don't need to copy them at all. The problem can be solved by only deserializing key fields from tuple and copy them to `dst_row` when it's a new key. HLL and bitmap columns only need to be initialized once and no copy are needed. +1. But the change is a little bigger. I think we should as soon as possible merge this PR or revert https://github.com/apache/incubator-doris/commit/177fec8917304e399aa7f3facc4cc4804e72ce8b and to make **master branch work well.** The master branch shouldn't be broken a long time.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
