imay commented on a change in pull request #2430: Fix BE
do_tablet_meta_checkpoint retain _meta_lock for a long time
URL: https://github.com/apache/incubator-doris/pull/2430#discussion_r356608968
##########
File path: be/src/olap/rowset/rowset_meta.h
##########
@@ -296,6 +296,19 @@ class RowsetMeta {
return has_version() && _rowset_meta_pb.start_version() ==
_rowset_meta_pb.end_version();
}
+ // Some time, we may check if this rowset is in rowset meta manager's meta
by using RowsetMetaManager::check_rowset_meta.
+ // But, this check behavior may cost a lot of time when it is frequent.
+ // If we explicitly remove this rowset from rowset meta manager's meta, we
can set _is_removed_from_rowset_meta to true,
+ // And next time when we want to check if this rowset is in rowset mata
manager's meta, we can
+ // check is_remove_from_rowset_meta() first.
+ void set_remove_from_rowset_meta() {
+ _is_removed_from_rowset_meta = true;
+ }
+
+ bool is_remove_from_rowset_meta() {
Review comment:
```suggestion
bool is_remove_from_rowset_meta() const {
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
