kangpinghuang commented on a change in pull request #2549: fix segment size
URL: https://github.com/apache/incubator-doris/pull/2549#discussion_r361175392
##########
File path: be/src/olap/rowset/segment_v2/column_writer.cpp
##########
@@ -250,22 +249,24 @@ Status ColumnWriter::write_data() {
_page_builder->get_dictionary_page(&dict_page);
std::vector<Slice> origin_data;
origin_data.push_back(dict_page.slice());
- RETURN_IF_ERROR(_write_physical_page(&origin_data, &_dict_page_pp));
+ RETURN_IF_ERROR(_write_slices(&origin_data));
}
return Status::OK();
}
Status ColumnWriter::write_ordinal_index() {
Slice data = _ordinal_index_builder->finish();
std::vector<Slice> slices{data};
- return _write_physical_page(&slices, &_ordinal_index_pp);
+ auto st = _write_slices(&slices);
+ return st;
}
Status ColumnWriter::write_zone_map() {
if (_opts.need_zone_map) {
OwnedSlice data = _column_zone_map_builder->finish();
- std::vector<Slice> slices{data.slice()};
- return _write_physical_page(&slices, &_zone_map_pp);
+ std::vector<Slice> slices;
+ slices.push_back(data.slice());
Review comment:
done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
