morningman commented on a change in pull request #2553: Add filter conditions
for 'show partitions from table' syntax
URL: https://github.com/apache/incubator-doris/pull/2553#discussion_r361653534
##########
File path: fe/src/main/java/org/apache/doris/analysis/ShowPartitionsStmt.java
##########
@@ -73,17 +107,7 @@ public ProcNodeInterface getNode() {
@Override
public void analyze(Analyzer analyzer) throws AnalysisException,
UserException {
- super.analyze(analyzer);
-
- if (Strings.isNullOrEmpty(dbName)) {
- dbName = analyzer.getDefaultDb();
- if (Strings.isNullOrEmpty(dbName)) {
- throw new AnalysisException("No db name in show data
statement.");
- }
- } else {
- dbName = ClusterNamespace.getFullName(getClusterName(), dbName);
- }
-
+ analyzeSynTax(analyzer);
Review comment:
`analyze` itself means `analyze syntax`, so no need to name like
`analyzeSynTax`.
`analyzeImpl` is better. Like named in other class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
