imay commented on a change in pull request #2682: Fix incompatibility with arm
architecture in olap #2645
URL: https://github.com/apache/incubator-doris/pull/2682#discussion_r363598855
##########
File path: be/src/olap/rowset/segment_group.h
##########
@@ -291,7 +291,7 @@ class SegmentGroup {
PUniqueId _load_id; // load id for segmentgroup
int32_t _num_segments; // number of segments in this
segmentgroup
bool _index_loaded; // whether the segmentgroup has been
read
- atomic_t _ref_count; // reference count
+ base::subtle::Atomic64 _ref_count; // reference count
Review comment:
prefer std::atomic<int32_t>.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
