imay commented on a change in pull request #2746: Support ends_with function
URL: https://github.com/apache/incubator-doris/pull/2746#discussion_r365799262
##########
File path: be/src/exprs/string_functions.cpp
##########
@@ -79,6 +79,13 @@ StringVal StringFunctions::right(
return substring(context, str, IntVal(pos), len);
}
+IntVal StringFunctions::ends_with(
Review comment:
1. should check if input str and suffix is null.
2. return value is a BoolVal?
3. better add a unit test for this new added function
You can reference
[here](https://github.com/apache/incubator-doris/pull/2731/files#diff-5e4308868edc8f5148f449c84f8428ffR281)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
