caiconghui commented on a change in pull request #2737: Support replication_num 
setting for table level
URL: https://github.com/apache/incubator-doris/pull/2737#discussion_r366287489
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/catalog/OlapTable.java
 ##########
 @@ -1203,4 +1203,19 @@ public boolean 
convertRandomDistributionToHashDistribution() {
         }
         return hasChanged;
     }
+
+    public void setReplicationNum(Short replicationNum) {
+        if (tableProperty == null) {
+            tableProperty = new TableProperty(new HashMap<String, String>());
+        }
+        
tableProperty.getProperties().put(PropertyAnalyzer.PROPERTIES_REPLICATION_NUM, 
replicationNum.toString());
+    }
+
+    public Short getReplicationNum() {
 
 Review comment:
   I think that may confused user. Because the user doesn't set the 
replication_num in table level,
   however, FeConstants.default_replication_num can be changed by admin, and 
when user don't modify config for table, he may find the replication_num config 
in table level changed, return null indicate that we don't set any 
replication_num config in table level, and then we use 
FeConstants.default_replication_num

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to