morningman commented on a change in pull request #2763: [Alter]Add wait time
while doing alter options
URL: https://github.com/apache/incubator-doris/pull/2763#discussion_r366373998
##########
File path: fe/src/main/java/org/apache/doris/alter/Alter.java
##########
@@ -273,6 +276,18 @@ public void processAlterTable(AlterTableStmt stmt) throws
UserException {
throw new DdlException("table with empty parition cannot do
schema change. [" + tableName + "]");
}
+ // if table state is unhealthy, change table repair priority, and
wait until repair finish or exceed timeout
+ if (olapTable.getState() != OlapTableState.NORMAL) {
Review comment:
First, `olapTable.getState() != OlapTableState.NORMAL` does not mean the
table is unhealthy.
Second, it's not good to sleep here, it will block the client connection for
a very long time.
Third, I don't think its good idea to add priority repair here. We should
solve more why the table is often unhealthy, rather than increase the
complexity here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
