morningman commented on a change in pull request #2877: [FIX] fix a bug when
using grouping set without all column in a grouping set item
URL: https://github.com/apache/incubator-doris/pull/2877#discussion_r377636196
##########
File path: be/src/exec/repeat_node.cpp
##########
@@ -30,6 +30,7 @@ RepeatNode::RepeatNode(ObjectPool* pool, const TPlanNode&
tnode,
const DescriptorTbl& descs)
: ExecNode(pool, tnode, descs),
_slot_id_set_list(tnode.repeat_node.slot_id_set_list),
+ _all_slot_id(tnode.repeat_node.all_slot_id),
Review comment:
rename to `_all_slot_ids`.
And `tnode.repeat_node.all_slot_id` should be optional, so here you need to
check whether this field is set.
Since this is a bug, you can just return ERROR if this field is not set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
