Seaven commented on a change in pull request #2979: Incomplete support Array
type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386223835
##########
File path: be/src/udf/udf.h
##########
@@ -786,6 +792,31 @@ struct HllVal : public StringVal {
void agg_merge(const HllVal &other);
};
+struct CollectionVal : public AnyVal {
Review comment:
I referenced the implementation of Impala, nested type(array, map) is used
same struct to describe, the different is the data in struct, so I think we can
also use same struct. Personally, I also think called ArrayVal and ArrayValue
is good idea
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]