morningman commented on a change in pull request #2979: Incomplete support 
Array type (#2871)
URL: https://github.com/apache/incubator-doris/pull/2979#discussion_r386457002
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/ExpressionFunctions.java
 ##########
 @@ -221,6 +221,12 @@ public LiteralExpr invoke(List<Expr> args) throws 
AnalysisException {
             } else {
                 throw new IllegalArgumentException("Doris does't support 
type:" + argType);
             }
+
+            // if args all is NullLiteral
 
 Review comment:
   Why not using `argType.isNull()` and put this logic into above `if else` 
block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to