morningman commented on a change in pull request #2618: Add BE plugin framework
(#2348)
URL: https://github.com/apache/incubator-doris/pull/2618#discussion_r393056810
##########
File path: be/src/plugin/plugin.h
##########
@@ -15,11 +15,17 @@
// specific language governing permissions and limitations
// under the License.
+#ifndef DORIS_BE_PLUGIN_PLUGIN_H
+#define DORIS_BE_PLUGIN_PLUGIN_H
+
namespace doris {
-#define PLUGIN_NOT_DYNAMIC_INSTALL 1UL
+#define PLUGIN_TYPE_IMPORT 1
+#define PLUGIN_TYPE_STORAGE 2
+#define PLUGIN_TYPE_MAX 3
Review comment:
Only 3?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
