imay commented on a change in pull request #3143: Non blocking OlapTableSink
URL: https://github.com/apache/incubator-doris/pull/3143#discussion_r395953751
##########
File path: be/src/exec/tablet_sink.cpp
##########
@@ -611,57 +633,79 @@ Status OlapTableSink::close(RuntimeState* state, Status
close_status) {
// only if status is ok can we call this
_profile->total_time_counter().
// if status is not ok, this sink may not be prepared, so that
_profile is null
SCOPED_TIMER(_profile->total_time_counter());
+ int64_t serialize_batch_ns = 0, queue_push_lock_ns = 0,
actual_consume_ns = 0;
{
SCOPED_TIMER(_close_timer);
- for (auto channel : _channels) {
- status = channel->close(state);
- if (!status.ok()) {
- LOG(WARNING) << "close channel failed, load_id=" <<
print_id(_load_id)
- << ", txn_id=" << _txn_id;
- }
+ for (auto index_channel : _channels) {
+ index_channel->for_each_node_channel(
+ [&](NodeChannel* ch) { WARN_IF_ERROR(ch->mark_close(),
""); });
+ }
+
+ for (auto index_channel : _channels) {
+ index_channel->for_each_node_channel([&](NodeChannel* ch) {
Review comment:
change to explicit capture
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
