Youngwb commented on a change in pull request #3186: Support convert Arrow
data to RowBatch asynchronously in Spark-Doris-Connector
URL: https://github.com/apache/incubator-doris/pull/3186#discussion_r397712650
##########
File path:
extension/spark-doris-connector/src/main/java/org/apache/doris/spark/serialization/RowBatch.java
##########
@@ -70,7 +70,8 @@ public void put(Object o) {
}
}
- private int offsetInOneBatch = 0;
+ // offset for iterate the rowBatch
+ private int offsetInRowBatch = 0;
private int rowCountInOneBatch = 0;
Review comment:
rowCountInOneBatch is also used in `addValueToRow` and
`convertArrowToRowBatch`, so I think this is better for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
