kangkaisen commented on a change in pull request #3201: [Bug][Refactor] Fix the conflict of temp partition and dynamic partition operations URL: https://github.com/apache/incubator-doris/pull/3201#discussion_r398568426
########## File path: fe/src/main/java/org/apache/doris/alter/AlterOperations.java ########## @@ -0,0 +1,104 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.alter; + +import org.apache.doris.analysis.AlterClause; +import org.apache.doris.common.DdlException; + +import com.google.common.base.Joiner; +import com.google.common.collect.Sets; + +import java.util.List; +import java.util.Set; + +/* + * AlterOperations contains a set alter operations generated from a AlterStmt's alter clause. + * This class is mainly used to integrate these operation types and check whether they have conflicts. + */ +public class AlterOperations { + private Set<AlterOpType> currentOps = Sets.newHashSet(); + + public AlterOperations() { + } + + public Set<AlterOpType> getCurrentOps() { + return currentOps; + } + + // check the conflicts of the given list of alter clauses + public void checkConflict(List<AlterClause> alterClauses) throws DdlException { + for (AlterClause alterClause : alterClauses) { + checkOp(alterClause.getOpType()); + } + } + + // some operations take up disk space. so we need to check the disk capacity before processing. + // return true if we see these kind of opertions. + public boolean needCheckCapacity() { + for (AlterOpType currentOp : currentOps) { + if (currentOp.needCheckCapacity()) { + return true; + } + } + return false; + } + + public boolean hasPartitionOp() { + return currentOps.contains(AlterOpType.ADD_PARTITION) || currentOps.contains(AlterOpType.DROP_PARTITION) + || currentOps.contains(AlterOpType.REPLACE_PARTITION) || currentOps.contains(AlterOpType.MODIFY_PARTITION); + } + + // MODIFY_TABLE_PROPERTY is also processed by SchemaChangeHandler + public boolean hasSchemaChangeOp() { + return currentOps.contains(AlterOpType.SCHEMA_CHANGE) || currentOps.contains(AlterOpType.MODIFY_TABLE_PROPERTY); + } + + public boolean hasRollupOp() { + return currentOps.contains(AlterOpType.ADD_ROLLUP) || currentOps.contains(AlterOpType.DROP_ROLLUP); + } + + public boolean hasRenameOp() { + return currentOps.contains(AlterOpType.RENAME); + } + + // return true if it has specified operation Review comment: This comment could remove. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
