morningman commented on a change in pull request #3246: [metrics] Add some 
metrics for container size in BE
URL: https://github.com/apache/incubator-doris/pull/3246#discussion_r402117572
 
 

 ##########
 File path: be/src/runtime/result_buffer_mgr.cpp
 ##########
 @@ -33,6 +34,11 @@ namespace doris {
 
 ResultBufferMgr::ResultBufferMgr()
     : _is_stop(false) {
+    REGISTER_PRIVATE_VARIABLE_METRIC(result_buffer_block_count);
+    DorisMetrics::metrics()->register_hook("result_buffer_block_count", [&]() {
+        boost::lock_guard<boost::mutex> l(_lock);
 
 Review comment:
   ```suggestion
           std::lock_guard<boost::mutex> l(_lock);
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to