Seaven commented on a change in pull request #3267: [Bug] Fix some bugs of 
install/uninstall plugins
URL: https://github.com/apache/incubator-doris/pull/3267#discussion_r404534865
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/plugin/PluginMgr.java
 ##########
 @@ -86,25 +112,26 @@ public PluginInfo installPlugin(InstallPluginStmt stmt) 
throws IOException, User
 
         try {
             PluginInfo info = pluginLoader.getPluginInfo();
-
-            if (plugins[info.getTypeId()].containsKey(info.getName())) {
+            
+            if (checkDynamicPluginNameExist(info.getName())) {
 
 Review comment:
   Using two containers does not avoid concurrency problems

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to