caiconghui commented on a change in pull request #3386:
URL: https://github.com/apache/incubator-doris/pull/3386#discussion_r414693391
##########
File path: fe/src/main/java/org/apache/doris/mysql/nio/NMysqlServer.java
##########
@@ -47,7 +46,7 @@
private AcceptingChannel<StreamConnection> server;
// default task service.
- private ExecutorService taskService = Executors.newCachedThreadPool((new
ThreadFactoryBuilder().setDaemon(false).setNameFormat("doris-mysql-nio
TASK").build()));
+ private ExecutorService taskService =
ThreadPoolManager.newDaemonCacheThreadPool(Config.max_mysql_service_task_threads_num,
"doris-mysql-nio-pool");
Review comment:
It doesn't matter, because thread which submit task is not a daemon
thread. for the whole fe jvm process, only when there are no non-daemon threads
will cause jvm process exit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
