imay commented on a change in pull request #3405:
URL: https://github.com/apache/incubator-doris/pull/3405#discussion_r416258458
##########
File path: be/src/exec/olap_scan_node.cpp
##########
@@ -702,8 +694,13 @@ Status OlapScanNode::start_scan_thread(RuntimeState*
state) {
state, this, _olap_scan_node.is_preaggregation,
_need_agg_finalize, *scan_range, scanner_ranges);
_scanner_pool->add(scanner);
_olap_scanners.push_back(scanner);
+
+ if (disk_set.find(scanner->scan_disk()) == disk_set.end()) {
+ disk_set.insert(scanner->scan_disk());
+ }
}
}
+ COUNTER_SET(_num_disks_accessed_counter,
static_cast<int64_t>(disk_set.size()));
Review comment:
What is this metric used for? If this metric is not useful, just remove
it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
