morningman commented on a change in pull request #3523:
URL: https://github.com/apache/incubator-doris/pull/3523#discussion_r422613324
##########
File path: fe/src/main/java/org/apache/doris/alter/AlterJob.java
##########
@@ -189,18 +189,14 @@ protected boolean checkBackendState(Replica replica) {
return false;
} else if (!backend.isAlive()) {
long currentTime = System.currentTimeMillis();
- if (backend.getLastUpdateMs() > 0
- && currentTime - backend.getLastUpdateMs() >
Config.max_backend_down_time_second * 1000) {
- // this backend is done for a long time and not restart
automatically.
- // we consider it as dead
- return false;
- }
- return true;
- } else if (backend.isDecommissioned()) {
- return false;
+ // this backend is done for a long time and not restart
automatically.
Review comment:
Change the comment to:
```
// If this backend is done for a long time and not restart automatically.
// we consider it as dead and return false.
```
##########
File path: fe/src/main/java/org/apache/doris/backup/RestoreJob.java
##########
@@ -806,7 +739,54 @@ private void checkAndPrepareMeta() {
// No log here, PENDING state restore job will redo this method
LOG.info("finished to prepare meta and send snapshot tasks, num: {}.
{}",
batchTask.getTaskNum(), this);
- return;
+ }
+
+ private boolean backupReplicasNotEqual(PartitionInfo localPartInfo,
Partition localPartition, Table localTbl,
Review comment:
I think the part of `generate file mapping` can be a separated method
not including in this method.
Or the name of this method can be confused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
