EmmyMiao87 commented on a change in pull request #3571:
URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r424859796
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -343,14 +367,19 @@ StringVal
BitmapFunctions::bitmap_hash(doris_udf::FunctionContext* ctx, const do
}
StringVal BitmapFunctions::bitmap_serialize(FunctionContext* ctx, const
StringVal& src) {
- auto src_bitmap = reinterpret_cast<BitmapValue*>(src.ptr);
- StringVal result = serialize(ctx, src_bitmap);
- delete src_bitmap;
- return result;
+ if (src.is_null) {
+ BitmapValue src_bitmap;
+ return serialize(ctx, &src_bitmap);
+ } else {
+ auto src_bitmap = reinterpret_cast<BitmapValue*>(src.ptr);
+ StringVal result = serialize(ctx, src_bitmap);
+ delete src_bitmap;
Review comment:
The src_bitmap was initialized in merge function. So it need to delete
src_bitmap when UDA has been finished.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
