HappenLee commented on code in PR #19122:
URL: https://github.com/apache/doris/pull/19122#discussion_r1178575516
##########
be/src/vec/sink/vmysql_result_writer.cpp:
##########
@@ -605,107 +611,113 @@ Status
VMysqlResultWriter<is_binary_format>::append_block(Block& input_block) {
// convert one batch
auto result = std::make_unique<TFetchDataResult>();
for (int i = 0; status.ok() && i < _output_vexpr_ctxs.size(); ++i) {
- auto column_ptr =
block.get_by_position(i).column->convert_to_full_column_if_const();
+ const auto& [column_ptr, col_const] =
unpack_if_const(block.get_by_position(i).column);
auto type_ptr = block.get_by_position(i).type;
+ if (UNLIKELY(num_rows != block.get_by_position(i).column->size())) {
Review Comment:
Better change to DCHECK
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
