yixiutt commented on code in PR #17542:
URL: https://github.com/apache/doris/pull/17542#discussion_r1178576198
##########
be/src/olap/tablet.cpp:
##########
@@ -2515,15 +2611,29 @@ Status Tablet::_load_rowset_segments(const
RowsetSharedPtr& rowset,
}
// caller should hold meta_lock
-Status Tablet::calc_delete_bitmap(RowsetId rowset_id,
+Status Tablet::calc_delete_bitmap(RowsetSharedPtr rowset,
const
std::vector<segment_v2::SegmentSharedPtr>& segments,
const RowsetIdUnorderedSet*
specified_rowset_ids,
DeleteBitmapPtr delete_bitmap, int64_t
end_version,
- bool check_pre_segments) {
+ bool check_pre_segments, RowsetWriter*
rowset_writer) {
std::vector<segment_v2::SegmentSharedPtr> pre_segments;
OlapStopWatch watch;
Version dummy_version(end_version + 1, end_version + 1);
+ auto rowset_id = rowset->rowset_id();
+ auto rowset_schema = rowset->tablet_schema();
+ bool is_partial_update = rowset_schema->is_partial_update();
+ // use for partial update
+ std::map<RowsetId, std::map<uint32_t, std::vector<RidAndPos>>>
read_plan_ori;
+ std::map<RowsetId, std::map<uint32_t, std::vector<RidAndPos>>>
read_plan_update;
+
+ std::map<RowsetId, RowsetSharedPtr> rsid_to_rowset;
+ rsid_to_rowset[rowset_id] = rowset;
+ vectorized::Block block = rowset_schema->create_block();
+ uint32_t pos = 0;
+ StorageReadOptions opt;
+ auto block_row_max = opt.block_row_max;
+
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
