kangkaisen commented on a change in pull request #3571:
URL: https://github.com/apache/incubator-doris/pull/3571#discussion_r427714328
##########
File path: be/src/exprs/bitmap_function.cpp
##########
@@ -302,6 +302,31 @@ void BitmapFunctions::bitmap_union(FunctionContext* ctx,
const StringVal& src, S
}
}
+// this is the read init function for bitmap_intersect
+void BitmapFunctions::bitmap_intersect_init_real(FunctionContext* ctx,
StringVal* dst) {
Review comment:
这个init函数是通用的，将来不止bitmap_intersect 会用到。
当前 bitmap_init 的实现是not nullable的，所以你这个函数合理的命名应该是nullable_bitmap_init，
或者bitmap_nullable_init.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
