github-actions[bot] commented on code in PR #18654:
URL: https://github.com/apache/doris/pull/18654#discussion_r1179867777
##########
be/test/vec/jsonb/serialize_test.cpp:
##########
@@ -302,7 +316,8 @@
MutableColumnPtr col = ColumnString::create();
// serialize
JsonbSerializeUtil::block_to_jsonb(schema, block,
static_cast<ColumnString&>(*col.get()),
- block.columns());
+ block.columns(),
+
create_data_type_serdes(block.get_data_types()));
// deserialize
TupleDescriptor read_desc(PTupleDescriptor(), true);
Review Comment:
warning: calling a private constructor of class 'doris::TupleDescriptor'
[clang-diagnostic-error]
```cpp
TupleDescriptor read_desc(PTupleDescriptor(), true);
^
```
**be/src/runtime/descriptors.h:366:** declared private here
```cpp
TupleDescriptor(const PTupleDescriptor& tdesc, bool own_slot = false);
^
```
##########
be/test/vec/jsonb/serialize_test.cpp:
##########
@@ -322,8 +337,12 @@
read_desc.add_slot(slot);
Review Comment:
warning: 'add_slot' is a private member of 'doris::TupleDescriptor'
[clang-diagnostic-error]
```cpp
read_desc.add_slot(slot);
^
```
**be/src/runtime/descriptors.h:370:** declared private here
```cpp
void add_slot(SlotDescriptor* slot);
^
```
##########
be/test/vec/jsonb/serialize_test.cpp:
##########
@@ -152,8 +159,15 @@
read_desc.add_slot(slot2);
Review Comment:
warning: 'add_slot' is a private member of 'doris::TupleDescriptor'
[clang-diagnostic-error]
```cpp
read_desc.add_slot(slot2);
^
```
**be/src/runtime/descriptors.h:370:** declared private here
```cpp
void add_slot(SlotDescriptor* slot);
^
```
##########
be/test/vec/jsonb/serialize_test.cpp:
##########
@@ -126,12 +128,15 @@ TEST(BlockSerializeTest, Array) {
MutableColumnPtr col = ColumnString::create();
// serialize
JsonbSerializeUtil::block_to_jsonb(schema, block,
static_cast<ColumnString&>(*col.get()),
- block.columns());
+ block.columns(),
+
create_data_type_serdes(block.get_data_types()));
// deserialize
TupleDescriptor read_desc(PTupleDescriptor(), true);
Review Comment:
warning: calling a private constructor of class 'doris::TupleDescriptor'
[clang-diagnostic-error]
```cpp
TupleDescriptor read_desc(PTupleDescriptor(), true);
^
```
**be/src/runtime/descriptors.h:366:** declared private here
```cpp
TupleDescriptor(const PTupleDescriptor& tdesc, bool own_slot = false);
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
