yangzhg commented on a change in pull request #3641:
URL: https://github.com/apache/incubator-doris/pull/3641#discussion_r427863742
##########
File path: be/src/olap/data_dir.cpp
##########
@@ -709,13 +716,29 @@ OLAPStatus DataDir::load() {
return true;
};
OLAPStatus load_tablet_status = TabletMetaManager::traverse_headers(_meta,
load_tablet_func);
- if (failed_tablet_ids.size() != 0 && !config::ignore_load_tablet_failure) {
- LOG(FATAL) << "load tablets from header failed, failed tablets size: "
<< failed_tablet_ids.size();
+ if (failed_tablet_ids.size() != 0) {
+ if (!config::ignore_load_tablet_failure) {
Review comment:
how about log warning first, and then
```
if (!config::ignore_load_tablet_failure) {
LOG(FATAL) << "be will shutdown due to ignore_load_tablet_failure is
false"
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
