morningman commented on a change in pull request #3661:
URL: https://github.com/apache/incubator-doris/pull/3661#discussion_r429508808
##########
File path: be/src/olap/schema_change.cpp
##########
@@ -1859,6 +1859,29 @@ OLAPStatus
SchemaChangeHandler::_parse_request(TabletSharedPtr base_tablet,
// 若Key列的引用序列出现乱序，则需要重排序
int num_default_value = 0;
+ // A, B, C are keys(sort keys), D is value
+ // The following cases are not changing the order, no need to resort:
+ // (sort keys keep in same order)
+ // old keys: A B C D
+ // new keys: A X B C D
+ //
+ // old keys: A B C D
+ // new keys: X A B C D
+ //
+ // old keys: A B C D
+ // new keys: A B C
+ //
+ // old keys: A B C D
+ // new keys: A B
Review comment:
Sorry that this PR is not ready, I will consider more situation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
